feat: better failure messages when reading too much input #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Note: This cast could be truncating | ||
| ctx.rt.state.input_stream.front().map(|data| data.len() as u32) | ||
| // Note: This cast could be truncating on 64bit systems. |
There was a problem hiding this comment.
I'm confused by this comment. Is the call below safe?
There was a problem hiding this comment.
The length field of a vec is a usize, which is 32 or 64 bit depending on target.
You might have a vec with len here that is greater than 2^32 - 1, but it would fail in the vm (based on the checks done there) and if those werent there, it would fail while reading into uninit memory.
nhtyy
commented
Jan 17, 2025
nhtyy
commented
Jan 17, 2025
ratankaliani
approved these changes
Jan 17, 2025
Comment on lines
-43
to
-45
| // 1. `ptr` was allocated using alloc | ||
| // 2. Assume that the allocator in the VM doesn't deallocate in the input space. | ||
| // 3. Size and length are correct from above. Length is <= capacity. |
There was a problem hiding this comment.
Shouldn't we keep this comment?
Co-authored-by: Ratan Kaliani <[email protected]>
Co-authored-by: Ratan Kaliani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, reading to much input would panic the executor and lead to ambiguous error messages,
this change means that u32::MAX len vecs will fail. It displays the callsite of
readorread_vec