Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comments based on best practices from Effective Go #1223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodeLingoTeam
Copy link

Hi, we updated an exported function comment based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #1223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files          21       21           
  Lines        2931     2931           
=======================================
  Hits         2244     2244           
  Misses        614      614           
  Partials       73       73
Impacted Files Coverage Δ
lib/log.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925b38b...3e13dee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants