Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

submit snapshot migration quest #9

Closed
wants to merge 5 commits into from
Closed

submit snapshot migration quest #9

wants to merge 5 commits into from

Conversation

0xNomind
Copy link

@0xNomind 0xNomind commented Oct 1, 2023

please review my submission :)

@subsquid-quests subsquid-quests deleted a comment from darshsui Oct 1, 2023
Copy link
Contributor

@dariaag dariaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squid doesn't work, requires fixes

@abernatskiy
Copy link
Contributor

Was able to run the squid. Issues

  1. Data filters in the handler are insufficient. See https://docs.subsquid.io/evm-indexing/configuration/caveats/.
  2. Block entities should be buffered then batch-saved. See https://docs.subsquid.io/basics/batch-processing/.

@0xNomind
Copy link
Author

0xNomind commented Oct 2, 2023

please review again @dariaag @abernatskiy

@0xNomind 0xNomind requested a review from dariaag October 2, 2023 14:10
@dariaag
Copy link
Contributor

dariaag commented Oct 2, 2023

Was not able to run the squid. Please run the squid and verify that it works before submitting.
There is a naming conflict for type Block and Block entity. Block entity needs to be renamed.

@0xNomind
Copy link
Author

0xNomind commented Oct 2, 2023

Was not able to run the squid. Please run the squid and verify that it works before submitting. There is a naming conflict for type Block and Block entity. Block entity needs to be renamed.

Its work on my PC, and im check before submitting. Maybe forget to run sqd migration:generate and got conflict on database

Screenshot from 2023-10-02 22-42-12

@0xNomind
Copy link
Author

0xNomind commented Oct 2, 2023

owh you mention about this @dariaag export type Block = BlockHeader<Fields>. Oke i will fix that by rename the Block entity. Thanks

@abernatskiy
Copy link
Contributor

See 0xNomind/snapshot-squid#2

@RaisyaSyaifania
Copy link

please review my submission :)

@belopash
Copy link
Contributor

belopash commented Oct 5, 2023

closed in favor of #17 (to reduce duplications)

@belopash belopash closed this Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants