-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xdm.md #39
base: main
Are you sure you want to change the base?
Update xdm.md #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits but LGTM
@@ -286,18 +287,18 @@ Before sending any messages, domain needs to have an channel open with the `dst_ | |||
|
|||
### Close Channel | |||
|
|||
Any domain of either end of the open channel can close the channel: | |||
Any domain of either end of an `Open` or `Initiated` channel can close the channel: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not done yet but will be handled in next PR. Currently just Open channels can be closed. FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. The spec is prescriptive here of what should be happenning.
A few clarifications based on autonomys/subspace#2815