Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate PublishNotReadyAddresses flag to GN internal service #3219

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Propagate PublishNotReadyAddresses flag to GN internal service #3219

merged 1 commit into from
Nov 18, 2024

Conversation

tpantelis
Copy link
Contributor

Fixes #3216

@tpantelis tpantelis self-assigned this Nov 18, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3219/tpantelis/publish_not_ready
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis added ready-to-test When a PR is ready for full E2E testing backport This change requires a backport to eligible release branches release-note-needed Should be mentioned in the release notes labels Nov 18, 2024
@tpantelis tpantelis enabled auto-merge (rebase) November 18, 2024 16:38
@tpantelis tpantelis merged commit 56490aa into submariner-io:devel Nov 18, 2024
73 of 74 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3219/tpantelis/publish_not_ready]

@tpantelis tpantelis mentioned this pull request Nov 18, 2024
Open
@tpantelis tpantelis mentioned this pull request Nov 18, 2024
Open
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Nov 18, 2024
@tpantelis
Add 0.20 release note for submariner PR #3219
099e246 
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis mentioned this pull request Nov 18, 2024
Open
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Nov 18, 2024
@tpantelis
Add 0.18 release note for submariner PR #3219
4861680 
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis mentioned this pull request Nov 18, 2024
Open
@dfarrell07
Copy link
Member

I see the backports are for 0.18 and 0.19 but the release notes are for 0.18 and 0.20. Should there also be a 0.19 release note?

@dfarrell07
Copy link
Member

I see the backports are for 0.18 and 0.19 but the release notes are for 0.18 and 0.20. Should there also be a 0.19 release note?

Oh there is one it's just not linked here submariner-io/submariner-website#1212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yboaron yboaron yboaron approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

@tpantelis tpantelis

Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
Submariner 0.20
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Honor publishNotReadyAddresses flag for non headless services
4 participants
@tpantelis @submariner-bot @dfarrell07 @yboaron