Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect post creation page to API #148

Merged
merged 29 commits into from
May 14, 2024
Merged

Conversation

kgilles
Copy link
Member

@kgilles kgilles commented May 6, 2024

Noticeable Changes

  • Replaces existing post-creation placeholder form with a proper one based on the API specs
  • Connects said form and actions to API, allowing post creation
  • Creates new Selector component

Note that it's currently not possible to create a post without a URL because of sublinks/sublinks-api#385. Plus, image uploads are being giving an incorrect URL so they won't show up properly until sublinks/sublinks-api#357 is resolved.


Screenshot 2024-05-06 at 12 46 12 PM
Screenshot 2024-05-06 at 12 46 00 PM

@kgilles kgilles requested a review from a team as a code owner May 6, 2024 17:38
@kgilles kgilles linked an issue May 6, 2024 that may be closed by this pull request
@Pdzly
Copy link
Member

Pdzly commented May 7, 2024

I think there should be an option to have it controlled with url query params. like
?community=someid&title=MyNeWTitle.....
But this can be done after this.

@Pdzly
Copy link
Member

Pdzly commented May 7, 2024

sublinks/sublinks-api#386

This PR should fix the first issue you mentioned.

@kgilles
Copy link
Member Author

kgilles commented May 7, 2024

I think there should be an option to have it controlled with url query params. like ?community=someid&title=MyNeWTitle..... But this can be done after this.

@Pdzly Not a bad idea. Have you seen this implemented in any Lemmy instances/themes?

I've created an idea issue for this. And semi-related I also created a follow-up to prefill the community selector when navigating from a community page: #150

Copy link
Member

@Pdzly Pdzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@kgilles kgilles merged commit 15af7e3 into main May 14, 2024
5 checks passed
@kgilles kgilles deleted the 14-connect-post-create-page-to-api branch May 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect post create page to API
2 participants