Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit tests to SearchServiceTests #423

Closed
wants to merge 2 commits into from
Closed

feat: add unit tests to SearchServiceTests #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
217c54c
feat: add unit tests to SearchServiceTests
Jun 20, 2024
ce9b0a6
Merge branch 'main' into Add-more-unit-test-coverage-to-Search-packag…
Pdzly Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 137 additions & 2 deletions src/test/java/com/sublinks/sublinksapi/search/services/SearchServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.sublinks.sublinksapi.search.repositories.PostSearchRepository;
import com.sublinks.sublinksapi.utils.UrlUtil;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
import org.mockito.Mock;
Expand Down Expand Up @@ -123,15 +124,149 @@ public void testSearchPostByUrlReturnsEmptyWhenNoCrossPostsFound() {
assertEquals(expectedPage, result);
}

@Disabled
@Test
public void testSearchPostByUrlWithCrossPostsReturnsResults() {
public void testSearchPostByUrlReturnsEmptyWhenNoPosts() {
String url = "http://example.com";
int page = 0;
int pageSize = 2;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";


CrossPost crossPost = new CrossPost();
crossPost.setPosts(Collections.emptySet());

when(urlUtil.normalizeUrl(url)).thenReturn(cleanUrl);
when(postService.getStringMd5Hash(cleanUrl)).thenReturn(hash);
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

Page<Post> expectedPage = Page.empty();
Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);

assertEquals(expectedPage, result);
}

@Disabled
@Test
public void testSearchPostByUrlWithCrossPostsFewerPostsThanPageSize() {
String url = "http://example.com";
int page = 0;
int pageSize = 5;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";

Post post1 = new Post();
Post post2 = new Post();
Set<Post> posts = Set.of(post1,post2);
CrossPost crossPost = new CrossPost();
crossPost.setPosts(posts);

when(urlUtil.normalizeUrl(url)).thenReturn(cleanUrl);
when(postService.getStringMd5Hash(cleanUrl)).thenReturn(hash);
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

Page<Post> expectedPage = Page.empty();

Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);

assertEquals(expectedPage, result);
}

@Disabled
@Test
public void testSearchPostByUrlWithCrossPostsOnePageWorthOfPostsRequestSecondPage() {
String url = "http://example.com";
int page = 1;
int pageSize = 2;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";

Post post1 = new Post();
Post post2 = new Post();
Set<Post> posts = Set.of(post1,post2);
CrossPost crossPost = new CrossPost();
crossPost.setPosts(posts);

when(urlUtil.normalizeUrl(url)).thenReturn(cleanUrl);
when(postService.getStringMd5Hash(cleanUrl)).thenReturn(hash);
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

Page<Post> expectedPage = Page.empty();

Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);

assertEquals(expectedPage, result);
}

@Test
public void testSearchPostByUrlWithCrossPostsReturnsExactlyOnePageWorthOfResults() {
String url = "http://example.com";
int page = 0;
int pageSize = 2;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";

Post post1 = new Post();
Post post2 = new Post();
Set<Post> posts = Set.of(post1,post2);
CrossPost crossPost = new CrossPost();
crossPost.setPosts(posts);

when(urlUtil.normalizeUrl(url)).thenReturn(cleanUrl);
when(postService.getStringMd5Hash(cleanUrl)).thenReturn(hash);
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

List<Post> postList = crossPost.getPosts().stream().toList();
Page<Post> expectedPage = new PageImpl<>(postList,
PageRequest.of(page, pageSize, sort),posts.size());

Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);

assertEquals(expectedPage, result);
}

@Test
public void testSearchPostByUrlWithCrossPostsPageOneOfTwo() {
String url = "http://example.com";
int page = 0;
int pageSize = 1;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";

Post post1 = new Post();
Post post2 = new Post();
Set<Post> posts = Set.of(post1,post2);
CrossPost crossPost = new CrossPost();
crossPost.setPosts(posts);

when(urlUtil.normalizeUrl(url)).thenReturn(cleanUrl);
when(postService.getStringMd5Hash(cleanUrl)).thenReturn(hash);
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

List<Post> postList = crossPost.getPosts().stream().toList();
Page<Post> expectedPage = new PageImpl<>(postList.subList(0, 1),
PageRequest.of(page, pageSize, sort),posts.size());

Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);

assertEquals(expectedPage, result);
}

@Test
public void testSearchPostByUrlWithCrossPostsPageTwoOfTwo() {
String url = "http://example.com";
int page = 1;
int pageSize = 1;
Sort sort = Sort.by("id");
String cleanUrl = "http://example.com/clean";
String hash = "hashed-url";

Post post1 = new Post();
Post post2 = new Post();
Set<Post> posts = Set.of(post1,post2);
Expand All @@ -143,7 +278,7 @@ public void testSearchPostByUrlWithCrossPostsReturnsResults() {
when(crossPostRepository.getCrossPostByMd5Hash(hash)).thenReturn(Optional.of(crossPost));

List<Post> postList = crossPost.getPosts().stream().toList();
Page<Post> expectedPage = new PageImpl<>(postList.subList(page * pageSize, (page + 1) * pageSize),
Page<Post> expectedPage = new PageImpl<>(postList.subList(1, 2),
PageRequest.of(page, pageSize, sort),posts.size());

Page<Post> result = searchService.searchPostByUrl(url, page, pageSize, sort);
Expand Down