feat: add unit tests to SearchServiceTests #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add testSearchPostByUrlReturnsEmptyWhenNoPosts - fails, disabled add testSearchPostByUrlWithCrossPostsFewerPostsThanPageSize - fails, disabled add testSearchPostByUrlWithCrossPostsOnePageWorthOfPostsRequestSecondPage - fails, disabled rename testSearchPostByUrlWithCrossPostsReturnsExactlyOnePageWorthOfResults - passes add testSearchPostByUrlWithCrossPostsPageOneOfTwo - passes add testSearchPostByUrlWithCrossPostsPageTwoOfTwo - passes
alter-kaker
force-pushed
the
Add-more-unit-test-coverage-to-Search-package-#407
branch
from
f9607eb to
217c54c
Compare
This was referenced Jun 20, 2024
lazyguru
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
My only comment here would be that it would probably be better to move some of the repeated blocks of code into either a setup() call or have a separate function you could call to configure the tests where you reuse that same block of code. Otherwise, thanks for the contribution! I'm going to leave the PR unmerged for 1 day to allow @jgrim or @Pdzly to weigh in if they want
|
Also, @alter-kaker would you be able to configure your git client to sign your commits? |
|
@alter-kaker please sign your commits |
|
I'm closing this PR as there has been no response to my requests for the commits to be signed. When/if you are able to sign your commits, please feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #407