Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues fixed from the old repo #32

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Various issues fixed from the old repo #32

merged 5 commits into from
Aug 31, 2020

Conversation

UltraInstinct05
Copy link
Contributor

This PR fixes the following issues raised on the old undocs repo.

  1. #266 where the presence of an extra <string></string> was throwing an expected element key error.
  2. #247 where the menu entry for New Plugin... was wrongly stated.
  3. #246 where the platform key was not documented in the reference section for menus.
  4. #226 which discusses about the hypothetical .sublime-options file. That paragraph is now removed.

This commit fixes issue 266 of the original undocs repo where the presence
of an erroneous <string></string> was raising an "expected element key"
error.
This commit fixes issue 247 of the original undocs repo where the
direction to get to the `New Plugin` menu entry was incorrect.

I had fixed this in an earlier commit so not sure why this is not carried
over in the new community docs.
This commit fixes issue 246 of the original undocs repo where the platform
keyword wasn't documented in the reference section for the menus.
This commit fixes issue 246 of the original undocs repo, where it was
referenced that custom snippet variables could be created using a non
existent `.sublime-options` file.

The issue also discusses how to add custom static variables but I don't
feel it is very helpful.
@FichteFoll
Copy link
Member

Thanks a lot for these arguably trivial but important fixes!

@FichteFoll FichteFoll merged commit 2b44fc6 into sublimetext-io:master Aug 31, 2020
@FichteFoll FichteFoll added the documentation Improvements or additions to documentation label Aug 31, 2020
@UltraInstinct05 UltraInstinct05 deleted the various_fixes branch September 1, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants