Remove language IDs configuration file #2586
Open
+50
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
predragnikolic
approved these changes
Jan 15, 2025
|
I will see to merge this if no other reviews appear. |
|
Maybe wait a day or two to see if there is anything that would be against this change. Because it is a somewhat breaking change. I wonder if this configuration file was ever used by anybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned in #2568 (comment) I see no use case for this configuration file. If there is some entry missing in the current language ID mapping (like a new syntax with unconventional base scope), it would be better for everyone to fix it directly in the LSP package, rather than allowing users to add individual overrides. If anyone sees any use case that I missed, please correct me if I'm wrong.