-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JavaScript] Add BigInt suffix and Numeric Separators #1294
Conversation
Based on #1049, do we want to add more specific scopes? For instance: 0x12345n
// ^^^^^^^^ constant.numeric.hex.js
// ^^ punctuation.definition.numeric.hex.js
// ^ storage.type.numeric.bigint.js This would be a reasonably simple change, but it would clobber most of this PR. |
Added |
Awesome, I was actually about to ask if you could add these scopes. Thanks for the proactive changes! |
One thing I noticed is that the scopes should be tweaked to: |
Perhaps like #1292 we can split this into improvements that affect Babel or at least one browser and hold off on the bigint suffix for now? |
The separators are implemented in Babel, and The standard JavaScript primitive numeric type is
Option 2 has the drawback of appearing a little odd to the uninitiated, although when |
Alright, that sounds reasonable to me. Since there isn't a distinction between int/float, let's leave the scopes as-is. Thanks for your work on this. |
[JavaScript] Add BigInt suffix and Numeric Separators
Implements the BigInt and Numeric Separators proposals. See #1269.