Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mono-sgen paxrat problem #59

Open
wants to merge 2 commits into
base: debian
Choose a base branch
from
Open

Fix mono-sgen paxrat problem #59

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4231f25
Fix mono-sgen paxrat problem
oholiab Nov 12, 2017
683586a
Removed spurious paxrat args
oholiab Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions debian/build-hooks/H01paxrat_mono-sgen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/sh
# paxrat /usr/bin/mono-sgen before building environment to prevent build failure

apt-get install -y --force-yes paxrat
apt-get install -y --force-yes mono-runtime-sgen
paxrat /usr/bin/mono-sgen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paxrat should be called without any arguments or with different arguments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you or @dma comment on whether no args or different args are preferable, and if different what these should be?

I'll copy the fix over to the other PRs I have for the mono-sgen fix as well once I know what the right flags are.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the flag is present (it might not be if the package is pulled from stretch where the config is frozen), you would just paxrat it with no arguments. This will apply the flags from /etc/paxrat/paxrat.conf. If the flag is not present, it can be added to the conf first.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No args should work in all cases when the binary is included with flags in /etc/paxrat/paxrat.conf.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll try to get this done over the weekend because I want to test the change before I commit it :)

apt-get install -yf
2 changes: 2 additions & 0 deletions debian/gbp.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ upstream-tag = v%(version)s
overlay = True
export-dir = /tmp/build-area
upstream-tree = TAG
pbuilder = True
pbuilder-options = --hookdir ./debian/build-hooks

[dch]
debian-branch = debian
Expand Down