Support import of ListenBrainz recommendations playlists #1

orontee · 2024-03-23T16:36:34Z

Proposal

The proposed branch adds support for playlists returned by the playlists created for endpoint (recommendations playlists) from ListenBrainz API.

AFAICT the returned playlists are made of suggestions taken from previously listened tracks.

Implementation

The playlist descriptions are fetched by the existing Mopidy frontend during setup. Mopidy-Local database is then searched for matching tracks and Mopidy playlists are created using a trivial Mopidy backend dedicated to those playlists management.

The playlist import must be enabled using a new configuration key import_playlists (default to false).

Playlists are periodically updated (each week, on monday).

Possible improvements

Import all user playlists, not only recommendations
Make user playlists editable and synchronized with Listenbrainz
Import playlists from other users, but doesn't make much sense if one doesn't have a huge local library... What do you think?

Test

python -m pip install --upgrade --break-system-packages git+https://github.com/orontee/mopidy-listenbrainz.git@feature/playlists

Tried with both Argos and Iris.

orontee · 2024-03-23T20:21:47Z

Something is wrong with current implementation because .m3u8 files are created; It looks like the created playlists are handled by Mopidy-M3U and not the introduced backend...

UPDATE: Fixed an import exception with Mopidy 3.4.2, also missing name while creating playlists, and finally missing tracks.

suaviloquence · 2024-05-08T19:20:06Z

Thanks for the PR! Sorry for being so late, for some reason github did not notify me about it.

orontee · 2024-05-12T08:01:10Z

FYI, there's a regression in Iris, jaedb/Iris#953

suaviloquence

It looks good but I can't test it super well because I don't have the songs in my local backend. If you wanted to add configuration (here, in another PR) for that it would be awesome but I can still merge this one without it.

suaviloquence · 2024-05-13T00:11:25Z

README.rst

@@ -45,7 +45,8 @@ The following configuration values are available:
  Defaults to enabled.
 - ``listenbrainz/token``: Your `Listenbrainz user token <https://listenbrainz.org/profile/>`_
 - ``listenbrainz/url``: The URL of the API of the Listenbrainz instance to record listens to (default: api.listenbrainz.org)
-
+- ``listenbrainz/import_playlists``: Whether to import Listenbrainz playlists (default: ``false``)
+- ``listenbrainz/periodic_playlists_update``: Enable periodic import of Listenbrainz playlists (default: ``true``)


Suggested change

- ``listenbrainz/periodic_playlists_update``: Enable periodic import of Listenbrainz playlists (default: ``true``)

- ``listenbrainz/update_playlists``: Enable periodic import of Listenbrainz playlists (default: ``true``)

or something to keep the verb_noun order consistent. let me know if you think there's a better name

I understand and like the verb_noun paradigm.

May I suggest update_playlists_periodically, or monitor_playlists?

Thinking for a meaning full name, I realized that this configuration key is useless. Listenbrainz generates new recommendation playlists on each Monday, why would a user import playlists once and refuse to update when new recommendations are published? If Mopidy is restarted for whatever reason, the new recommendations are imported! Non-sense.

I thus propose to remove this configuration key.

mopidy_listenbrainz/ext.conf

mopidy_listenbrainz/backend.py

mopidy_listenbrainz/frontend.py

suaviloquence · 2024-05-13T00:21:12Z

mopidy_listenbrainz/frontend.py

+                # finally be deleted
+
+                logger.debug(f"Already known playlist {playlist_uri}")
+                # maybe there're new tracks in Mopidy's database...


Do you mean that the playlist has been updated since import? Do the playlists change?

From my experience, the playlists don't change from Listenbrainz backend point of view (but can't find the information in their documentation). From mopidy's point of view, they may change due to new tracks being imported in the library. The comment is related to that part.

mopidy_listenbrainz/frontend.py

suaviloquence · 2024-05-13T00:23:03Z

mopidy_listenbrainz/frontend.py

+            )
+            # search only in local database since other backends can
+            # be quite long to answer, should we offer choice through
+            # config?


I think this would be useful. For me no playlists are showing up because I use the mopidy-subidy extension exclusively

@suaviloquence The track search is not limited to Mopidy-Local anymore. The default is to search through all backends. The search_schemes configuration key allows to specify a list of schemes to limit the results to URIs with the given schemes.

Arggg... I just tried with my living room instance of Mopidy, a "production instance" with multiple backends. And
some backends seems to not support search by musicbrainz_trackid and not respect the API...

No idea how to fix this...

mai 14 22:18:07 argos mopidy[1925]: INFO [ListenbrainzFrontend-15 (_actor_loop)] mopidy_listenbrainz.frontend Importing ListenBrainz playlists mai 14 22:18:08 argos mopidy[1925]: INFO [InternetArchiveBackend-6 (_actor_loop)] mopidy_internetarchive.library Not searching Mopidy-InternetArchive: Keyword "musicbrainz_trackid" not supported mai 14 22:18:08 argos mopidy[1925]: ERROR [Core-11 (_actor_loop)] mopidy.core.library FileBackend backend returned bad data: Expected a SearchResult instance, not [] mai 14 22:18:08 argos mopidy[1925]: ERROR [Core-11 (_actor_loop)] mopidy.core.library StreamBackend backend returned bad data: Expected a SearchResult instance, not []

I suggest to have local: as default scheme for track searches and keep the documentation for users to be able to adapt to their favorite backend but warn them about many backends not supporting searches by musicbrainz id... Simple and acceptable to start with I guess.

orontee · 2024-05-13T05:28:44Z

It looks good but I can't test it super well because I don't have the songs in my local backend. If you wanted to add configuration (here, in another PR) for that it would be awesome but I can still merge this one without it.

Good point. I'll do it here, next week seems reasonable.

Co-authored-by: Max Carr <[email protected]>

suaviloquence

Looks good, awesome! ❤️ There are a few bugs about default config, but I think these suggestions should take care of that, let me know if they don't. Thanks for your work on this!

mopidy_listenbrainz/ext.conf

mopidy_listenbrainz/frontend.py

suaviloquence · 2024-05-15T17:13:19Z

mopidy_listenbrainz/frontend.py

+
+        for track_mbid in playlist_data.track_mbids:
+            query = self.library.search(
+                {"musicbrainz_trackid": [track_mbid]}, uris=search_schemes


For an enhancement later (doesn't need to be in this PR), does LB expose the artist/track name in the playlist response? Might help with finding tracks without tagged MBIDs (or maybe from a different album) if so.

Good point. I received recommendations on this topic in the Listenbrainz channel on Discourse: See https://community.metabrainz.org/t/support-for-recommendations-in-mopidy-listenbrainz/688258/6

suaviloquence · 2024-05-15T17:18:49Z

Also feel free to take credit and link yourself in the credits section of README.rst for your awesome work!

Co-authored-by: Max Carr <[email protected]>

suaviloquence · 2024-05-16T07:15:31Z

🎉

Support import of ListenBrainz playlists

8c30c74

Support Mopidy 3.4.x

b487711

orontee force-pushed the feature/playlists branch from 9fd3925 to b487711 Compare March 23, 2024 20:57

Fix missing playlist name

5e830db

orontee force-pushed the feature/playlists branch from d23988f to 5e830db Compare March 23, 2024 22:27

orontee added 2 commits March 23, 2024 23:48

Fix missing playlist tracks with Mopidy 3.4.x

8b08535

Periodic update of playlists

294de17

orontee force-pushed the feature/playlists branch from 3c62f20 to 294de17 Compare March 27, 2024 22:43

orontee changed the title ~~Support import of ListenBrainz playlists~~ Support import of ListenBrainz recommendations playlists Mar 29, 2024

Use a URI dedicated to recommendation playlists

96deeeb

orontee force-pushed the feature/playlists branch from ca2f78d to 96deeeb Compare March 29, 2024 06:15

suaviloquence self-requested a review May 8, 2024 19:37

orontee mentioned this pull request May 12, 2024

Playlists inconsistencies when using custom backend jaedb/Iris#953

Open

10 tasks

suaviloquence reviewed May 13, 2024

View reviewed changes

orontee and others added 7 commits May 13, 2024 07:37

Apply suggestions from code review

2b5c756

Co-authored-by: Max Carr <[email protected]>

Other changes related to code review

e1b4134

Remove useless configuration

2d01d45

Support track search in any backend

458457c

Fix format

e16a34e

Remove obsolete comment

930d175

Change default value of search_schemes

e2f2832

suaviloquence requested changes May 15, 2024

View reviewed changes

orontee and others added 2 commits May 16, 2024 07:26

Apply suggestions from code review

a8412ca

Co-authored-by: Max Carr <[email protected]>

Update to credits section

21ea159

suaviloquence merged commit f334052 into suaviloquence:master May 16, 2024

suaviloquence mentioned this pull request May 16, 2024

build recommendation playlists based on track name/author if MBID is missing #2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support import of ListenBrainz recommendations playlists #1

Support import of ListenBrainz recommendations playlists #1

orontee commented Mar 23, 2024 •

edited

Loading

orontee commented Mar 23, 2024 •

edited

Loading

suaviloquence commented May 8, 2024

orontee commented May 12, 2024

suaviloquence left a comment

suaviloquence May 13, 2024

orontee May 13, 2024

orontee May 13, 2024 •

edited

Loading

suaviloquence May 13, 2024

orontee May 13, 2024

suaviloquence May 13, 2024

orontee May 13, 2024

orontee May 14, 2024

orontee May 14, 2024

orontee commented May 13, 2024

suaviloquence left a comment

suaviloquence May 15, 2024

orontee May 16, 2024

suaviloquence commented May 15, 2024

suaviloquence commented May 16, 2024

	- ``listenbrainz/periodic_playlists_update``: Enable periodic import of Listenbrainz playlists (default: ``true``)
	- ``listenbrainz/update_playlists``: Enable periodic import of Listenbrainz playlists (default: ``true``)

Support import of ListenBrainz recommendations playlists #1

Support import of ListenBrainz recommendations playlists #1

Conversation

orontee commented Mar 23, 2024 • edited Loading

Proposal

Implementation

Possible improvements

Test

orontee commented Mar 23, 2024 • edited Loading

suaviloquence commented May 8, 2024

orontee commented May 12, 2024

suaviloquence left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orontee May 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orontee commented May 13, 2024

suaviloquence left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suaviloquence commented May 15, 2024

suaviloquence commented May 16, 2024

orontee commented Mar 23, 2024 •

edited

Loading

orontee commented Mar 23, 2024 •

edited

Loading

orontee May 13, 2024 •

edited

Loading