New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change for sliding plane when relative frame is used #2311

Open

FabianYan2010 wants to merge 23 commits into su2code:develop from FabianYan2010:Feature_SlidingPlane_RelFrame

+5,087 −4

FabianYan2010 commented Jun 25, 2024 •

edited

Loading

Proposed Changes

In some cases we use relative frame for rotor zone to perform URANS, e.g., in aeroelasticity analysis, we want the grid movement comes only from blade deformation. The problem is that the sliding plane in SU2 works only for absolute frame. In relative frame, the grid is not rotating, so the interpolation at sliding interface is not changed as time step is marching. The proposed changes rotate the sliding interface in accordance with physical time steps to perform interpolation. This function is activated only for relative frame. The grid itself is not rotating.
Currently, this is only implemented in CNearestneighbor class, other interpolation method should be changed as well in the near future.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

chuanxiang yan and others added 14 commits

November 21, 2023 17:57


          adapt the interpolation method NearestNeighbor to turbo applications …

d9b04db

…when rotating frame is used.


          Merge branch 'develop' into turbo_features_fabian

4461aa4


          For interface data broadcasting, we rotate the velocity vector from r…

76510d8

…otating frame zone.


          Update transfer coefficient every time step for when rotating frame i…

4477eff

…s adopted for unsteady simulation.


          For interface data broadcasting, we rotate the velocity vector from r…

5727ae6

…otating frame zone.


          For interface data broadcasting, we rotate the velocity vector from r…

f798a6b

…otating frame zone.


          For interface data broadcasting, we rotate the velocity vector from r…

d040cc4

…otating frame zone.


          Update transfer coefficient every time step for when rotating frame i…

c3fe7d2

…s adopted for unsteady simulation.


          New testcase proposed for this feature.

81ed71e


          Merge branch 'su2code:master' into turbo_features_fabian

4d32555


          update Merge branch 'master' of https://github.com/FabianYan2010/SU2

5f2f6ef


          Master branch was accidentally changed.

1fbc798

So we merge the mods on it to its real destination.

Merge branch 'master' into turbo_features_fabian


          clear tabs

a00878b


          Merge branch 'develop' into Feature_SlidingPlane_RelFrame

2a1dd3b

github-advanced-security bot found potential problems

View reviewed changes

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable cosTheta is not used.

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable sinTheta is not used.

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable cosPhi is not used.

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable sinPhi is not used.

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable cosPsi is not used.

SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp Outdated


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable sinPsi is not used.

bigfooted added changelog:feature changelog:fix labels

bigfooted reviewed

View reviewed changes

TestCases/turbomachinery/axial_stage_full_annulus_unsteady/rotor_FA_Unsteady.cfg Outdated

Comment on lines 5 to 8

+              % Author: S. Vitale                                                            %
+              % Institution: Delft University of Technology                                  %
+              % Date: Feb 28th, 2017                                                         %
+              % File Version 5.0.0"cardinal"                                                 %

Contributor

bigfooted Jun 26, 2024

Change authorship and get the credit that you deserve... Can you also add all new testcases to the regression tests, at least put it into parallel_regression.py

chuanxiang yan added 5 commits

July 29, 2024 14:55


          change authorship

1bb6796


          update test case

4fc50db


          change authorship

90a8859


          upload the grids and initial solution of the new test case

3f5d63d


          Merge branch 'Feature_SlidingPlane_RelFrame' of https://github.com/Fa…

be20596

…bianYan2010/SU2 into Feature_SlidingPlane_RelFrame

pcarruscag reviewed

View reviewed changes

Member

pcarruscag left a comment

Can you make this a config option as I mentioned before?
The large solution files need to be in the TestCases repo instead of together with the code.

pcarruscag changed the title ~~Change for sliding plane when relative frame is used~~ [WIP] Change for sliding plane when relative frame is used

chuanxiang yan added 4 commits

October 8, 2024 13:34


          remove solution and grid files from code repo

9d889bf


          add a cofig option for this feature

cbbf1bf


          remove unused variable

d53ae94


          add new option in test case config

059cc0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:feature changelog:fix