Merge pull request #2092 from su2code/preacc_performance

Improve parallel preacc performance
su2code · Jul 26, 2023 · 53563d9 · 53563d9
2 parents 7d0cd31 + a9a7ad8
commit 53563d9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/Common/include/basic_types/ad_structure.hpp b/Common/include/basic_types/ad_structure.hpp
@@ -384,16 +384,14 @@ FORCEINLINE void SetDerivative(int index, const double val) {
   if (index == 0)  // Allow multiple threads to "set the derivative" of passive variables without causing data races.
     return;
 
-  using BoundsChecking = codi::GradientAccessTapeInterface<su2double::Gradient, su2double::Identifier>::BoundsChecking;
-  AD::getTape().setGradient(index, val, BoundsChecking::False);
+  AD::getTape().setGradient(index, val, codi::AdjointsManagement::Manual);
 }
 
 // WARNING: For performance reasons, this method does not perform bounds checking.
 // If called after tape evaluations, the adjoints should exist.
 // Otherwise, please ensure sufficient adjoint vector size by a call to AD::ResizeAdjoints().
 FORCEINLINE double GetDerivative(int index) {
-  using BoundsChecking = codi::GradientAccessTapeInterface<su2double::Gradient, su2double::Identifier>::BoundsChecking;
-  return AD::getTape().getGradient(index, BoundsChecking::False);
+  return AD::getTape().getGradient(index, codi::AdjointsManagement::Manual);
 }
 
 FORCEINLINE bool IsIdentifierActive(su2double const& value) {

diff --git a/externals/codi b/externals/codi
diff --git a/externals/opdi b/externals/opdi
diff --git a/meson_scripts/init.py b/meson_scripts/init.py
@@ -55,11 +55,11 @@ def init_submodules(
 
     # This information of the modules is used if projects was not cloned using git
     # The sha tag must be maintained manually to point to the correct commit
-    sha_version_codi = "4237fe38c90b83541f699bd84e00c656099b7d18"
+    sha_version_codi = "17232fed05245dbb8f04a31e274a02d53458c75c"
     github_repo_codi = "https://github.com/scicompkl/CoDiPack"
     sha_version_medi = "aafc2d1966ba1233640af737e71c77c1a86183fd"
     github_repo_medi = "https://github.com/SciCompKL/MeDiPack"
-    sha_version_opdi = "913535c490989ea9aa654e8c7df41c7e3718a5a2"
+    sha_version_opdi = "c42cca71a3d0b44fb482e268ecd40b623e71776b"
     github_repo_opdi = "https://github.com/SciCompKL/OpDiLib"
     sha_version_meson = "41c650a040d50e0912d268af7a903a9ce1456dfa"
     github_repo_meson = "https://github.com/mesonbuild/meson"