New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list-item): Improve accessibility #240

Open

Anlerkan wants to merge 2 commits into main from fix/list-item-event-bubbling-and-accessibility-improvements

+19 −16

Contributor

Anlerkan commented May 13, 2024 •

edited

Loading

Replace onKeyPress with onKeyDown since onKeyPress is deprecated.
please see: https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event
Call onClick on space key press
Pass the same props to list item elements


          fix(list-item): fix event bubbling issue and improve accessibility

f7a4a64

Anlerkan added the ready for review label

Anlerkan requested review from jamcry, yasincaliskan, tatata96 and gulcinuras

May 13, 2024 09:11

Anlerkan self-assigned this


          fix: pass event directly to callback

959b183

Anlerkan changed the title ~~fix(list-item): Fix event bubbling issue and improve accessibility~~ fix(list-item): Improve accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review