fix(tab):generic id type added to TabItem #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gulcinuras
reviewed
Jan 23, 2023
There was a problem hiding this comment.
@tatata96 I asked a small change, but we can also discuss if that makes sense or not 😸
Also, I noticed that in 12-Tab.stories we are not providing the initialState in a Record type, so that it gives a type error.
Therefore, I think we can update the initialState on line 39 like this:
<StateProvider initialState={{index: 0}}>
and update the other places we use that state.
ErenYLCN
approved these changes
Jan 23, 2023
Anlerkan
reviewed
Jan 27, 2023
gulcinuras
approved these changes
Feb 2, 2023
edizcelik
approved these changes
Feb 23, 2023
tatata96
added
Ready for new release
Anlerkan
requested changes
Sep 12, 2023
yasincaliskan
approved these changes
Jan 11, 2024
jamcry
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue;
id#172