fix(tab):Generic type id added to tabItem #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gulcinuras
reviewed
Jan 16, 2023
Comment on lines
+52
to
+53
| console.log(items); | ||
|
|
There was a problem hiding this comment.
We can remove this I think
| @@ -136,7 +136,7 @@ export type ButtonProps = ButtonComponentProps; | |||
| export type DescriptionTermProps = DescriptionTermComponentProps; | |||
| export type FileUploadButtonProps = FileUploadButtonComponentProps; | |||
| export type SpinnerProps = SpinnerComponentProps; | |||
| export type TabItem = TabComponentItem; | |||
| export type TabItem <ID = number|string> = TabComponentItem <ID>; | |||
There was a problem hiding this comment.
Can you run prettify formatter to format all the files?
I think we can define the generic type for TabItem in Tab file instead of index.tsx:
export type TabItem<ID = number | string> = {
id: ID;
...
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues;
READY:
id#172WIP: