Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lib package update #215

Closed
wants to merge 10 commits into from
Closed

feat: lib package update #215

wants to merge 10 commits into from

Conversation

akgunberk
Copy link
Contributor

@akgunberk akgunberk commented Nov 30, 2022

[ ] - eslint gives error for constant numbers in @hipo-base-config ["0n"]
[ ] - storybook icon rendering plugin not working

to bypass first error for now, go to your node_modules/@hipo/eslint-config-base/common.js

replace the rule with following

    "no-magic-numbers": [
      "error",
      {
        ignore: [
          1,
          0,
          -1,
          // "0n"
        ]
      }
    ]

@akgunberk akgunberk added W.I.P Work in progress dependencies Pull requests that update a dependency file labels Nov 30, 2022
@akgunberk akgunberk requested a review from a team November 30, 2022 13:03
@akgunberk akgunberk self-assigned this Nov 30, 2022
@mucahit
Copy link
Contributor

mucahit commented Dec 28, 2022

@akgunberk is it ready to review? when we can finalize this

@akgunberk
Copy link
Contributor Author

@akgunberk is it ready to review? when we can finalize this

ready to review, we can say. we have 2 small issues i stated on description but I don't have time for this rn.
we can prioritize this if this is urgent, lets discuss ✌🏼

@yasincaliskan
Copy link
Contributor

Regarding the eslint "0n" issue, I didn't encounter this on my local. How can I reproduce it? 🤔 @akgunberk

@jamcry
Copy link
Collaborator

jamcry commented Mar 8, 2023

@akgunberk what is the status of this PR? Is it working?

@akgunberk
Copy link
Contributor Author

@akgunberk what is the status of this PR? Is it working?

@jamcry
it is on hold. there are two issues to be handled stated in description.
Testing also needed, it is been a while after creating this PR.

@akgunberk
Copy link
Contributor Author

duplicated with #228

@akgunberk akgunberk closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file W.I.P Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants