-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lib package update #215
Conversation
fix: stylelint error empty line before var fix: stylelint errors, modern rgb func
- do not extend any in generic components, its default - do not pass children as prop
@akgunberk is it ready to review? when we can finalize this |
ready to review, we can say. we have 2 small issues i stated on description but I don't have time for this rn. |
Regarding the eslint |
@akgunberk what is the status of this PR? Is it working? |
@jamcry |
duplicated with #228 |
[ ] - eslint gives error for constant numbers in
@hipo-base-config
["0n"][ ] - storybook icon rendering plugin not working
to bypass first error for now, go to your node_modules/@hipo/eslint-config-base/common.js
replace the rule with following