Skip to content

Commit

Permalink
Merge pull request #236 from Hipo/fix/update-workflow-node-version
Browse files Browse the repository at this point in the history
Update node versions for github workflows
  • Loading branch information
jamcry authored Mar 25, 2024
2 parents 23ea290 + 3ffc217 commit 3637c38
Show file tree
Hide file tree
Showing 5 changed files with 5,032 additions and 3,715 deletions.
19 changes: 13 additions & 6 deletions .github/workflows/new-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,22 @@ jobs:
publish:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- name: Setup repo
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 10
- run: npm install
- run: npm run build
node-version: 18.0.0

- name: Install dependencies
run: npm install

- name: Build
run: npm run build

- id: publish-to-npm
uses: JS-DevTools/npm-publish@v1
uses: JS-DevTools/npm-publish@v3
with:
token: ${{ secrets.NPM_TOKEN }} # This token should be added from repo settings

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18

- name: Install dependencies and build storybook
run: |
Expand Down
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,7 @@ Here is a simple example that shows how to customize `Button` and `Input`

### Development

Recommended system versions

- `node 14.x`
- `npm 7.x`
For recommended `node` and `npm` versions, you can check `package.json`

You can start to development with `npm run dev` command. The command watches for changes and builds the toolkit. If you want to generate a production ready build you can use `npm run build`.

Expand Down
Loading

0 comments on commit 3637c38

Please sign in to comment.