Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#23] Remove is_print_data , is_output parameter, and deprecated crawl.py. #28

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

stu01509
Copy link
Owner

  • Bugfix
  • New feature provided
  • Improve performance

描述 Description

FIX #23 Remove is_print_data and is_output parameter.

改動 Changes

  • Remove is_print_data and is_output parameter.
  • Deprecated crawl.py.

截圖 Screenshot

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +1.20% 🎉

Comparison is base (b58d04f) 64.95% compared to head (634392b) 66.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   64.95%   66.16%   +1.20%     
==========================================
  Files           2        2              
  Lines         214      198      -16     
==========================================
- Hits          139      131       -8     
+ Misses         75       67       -8     
Files Changed Coverage Δ
TaiwanLottery/__init__.py 78.23% <66.66%> (+2.77%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stu01509 stu01509 changed the title Task/23 [ISSUE-#23] Remove is_print_data , is_output parameter, and deprecated crawl.py. Aug 14, 2023
@stu01509 stu01509 merged commit ca46af7 into master Aug 15, 2023
5 checks passed
@stu01509 stu01509 deleted the task/23 branch August 15, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: Remove is_print_data and is_output
1 participant