Skip to content

Commit

Permalink
fix(node-18): revert changes to support node 18 again (#4935)
Browse files Browse the repository at this point in the history
Revert some dependency upgrades to fix compatibility issues with node 18.

- Revert `tap-parser`, `glob`, `minimatch`, `rimraf`, `tap` dependency updates.
- Remove direct dependency on `glob` for `@stryker-mutator/core`, since we only needed `hasMagic` from it, and that is also exported from `minimatch` (which was already a dependency).
- Make pipeline fail when `"EBADENGINE"` errors occur to prevent these issues in the future.
  • Loading branch information
nicojs authored Aug 6, 2024
1 parent 439f38c commit 42162bd
Show file tree
Hide file tree
Showing 20 changed files with 12,628 additions and 13,454 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
run: npm ci || npm ci # retry once, install on windows is flaky...
run: npm ci --engine-strict
- name: Build & lint & test
run: npm run all

Expand Down
Loading

0 comments on commit 42162bd

Please sign in to comment.