Remove legacy JPEG2000 encoder code #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jpeg2000 support was just barely added, and it is a valid format that can exist in HEIF files. Why do you think it needs to be removed? Besides, you missed a bunch of things, like the cmakelist. |
Please note the "legacy code". These are redundant parts (already no longer appearing in any CMakeList.txt, so dead code effectively), as both new JPEG2000 decoder and encoder source files have indeed been added and integrated recently. |
|
Oh, the openjpeg that's built-in instead of the outside library. I'm sorry, totally misread that diff. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.