Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: use recommended INCLUDE_DIRS form #918

Merged
merged 2 commits into from
Oct 9, 2023
Merged

CMake: use recommended INCLUDE_DIRS form #918

merged 2 commits into from
Oct 9, 2023

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Jul 3, 2023

Resolves #917

@kmilos kmilos force-pushed the cmake_include_dirs branch 2 times, most recently from 01dcc29 to 445cfac Compare July 3, 2023 16:26
@kmilos
Copy link
Contributor Author

kmilos commented Jul 3, 2023 •
edited
Loading

Could potentially drop the changes in all the FindXYZ.cmake files as superfluous, the plural variable is guaranteed by the libfind_process() call already... So only the 3 CMakeLists.txt files are absolutely necessary for the moment.

@kmilos
Copy link
Contributor Author

kmilos commented Jul 3, 2023

There is also no need for explicit addition of link library paths (those should've been added using target_link_directories() anyway), as "find" returns the full path to libraries...

@kmilos
Copy link
Contributor Author

kmilos commented Jul 18, 2023

Dropped find module changes, keeping just the minimal required now.

@farindk farindk merged commit f88aeab into strukturag:master Oct 9, 2023
29 of 30 checks passed
@farindk
Copy link
Contributor

farindk commented Oct 9, 2023

thanks

@kmilos kmilos deleted the cmake_include_dirs branch October 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake: use {libname}_INCLUDE_DIRS instead of {}_INCLUDE_DIR everywhere
2 participants
@kmilos @farindk