fix alpha encoding when using grid workaround #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itaibenari I think your first patch 8e930c2 is fine (if the alpha is encoded as monochrome and hence can have odd size). The second patch (5866f1a) is problematic because it appears to disable the whole 'clap' processing. This would break any correct codec just to match the error is macOS. Do we have any example case why we need to modify the 'clap' processing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the grid workaround the alpha
auxlitem refers to the image before it was wrapped in a grid (image_id) and causes alpha to be lost. so I changed the order and build the alpha layer after the main image.additionally, for small images (64px), there's an assertion that breaks at
heif_encoder_x265.cc:769, hence changed the alpha layer to be monochrome and only use Y.