Add framerate control to sherlock265 #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the thread to sleep for negative ms, effectively hanging it
This is capped because even on very fast machines, it wouldn't be able to decode faster than 300 fps
This is a performance enhancment, guessing that sleeping for 0 ms might have some performance penantly
This improves decoding precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds framerate control to sherlock265.
The framerate is controlled using a Qt SpinBox element.
Default framerate is 30, which is suitable for most videos but not all.
I tried extracting the video framerate from the SPS, which is analyzed inside libde265 internals, but is not readily accessible from outside. The only option appears to be to dump the whole SPS header and process it manually, or modify libde265 to provide it with the API, which is a bit out of scope right now.
Further work: