Only signal "stream negotiation success" once. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lynix can you try this out please?
[Edit2] You can test now. |
`rc` must be reset in order to make the `do-while` loop work in case there's no `sockopt_cb` set. Fixup of f346046 Signed-off-by: Steffen Jaeckel <[email protected]>
The code-path which checks whether the server requires an "xmpp-session" was untested and therefore the connection-callback handler was triggered twice with the state `XMPP_CONN_CONNECT`. This happened if the server supports stream-management and requires a session. Reported via profanity-im/profanity#1954 Fixup of c7d410f Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
fix-session
branch
from
d81f152
to
1cf09b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code-path which checks whether the server requires an "xmpp-session" was untested and therefore the connection-callback handler was triggered twice with the state
XMPP_CONN_CONNECT. This happened if the server supports stream-management and requires a session.Reported via profanity-im/profanity#1954
Fixup of c7d410f