move bitcoin utils to this repo #28
Conversation
| for (carry = uint8(data_[i]); m > high || carry != 0; m--) { | ||
| carry = carry + 256 * uint8(slot[uint256(m)]); | ||
| slot[uint256(m)] = bytes1(uint8(carry % 58)); | ||
| carry /= 58; |
There was a problem hiding this comment.
You can list such values as constants at the top for clarity and easier modifications.
| function slice(bytes memory data_, uint256 start_, uint256 end_) pure returns (bytes memory) { | ||
| unchecked { | ||
| bytes memory ret = new bytes(end_ - start_); | ||
| for (uint256 i = 0; i < end_ - start_; i++) { |
There was a problem hiding this comment.
If Im not mistaking, rewriting this loop using assembly would reduce gas price, but not sure how significant savings might be.
There was a problem hiding this comment.
Updated description of the PR, see above. For answers to these comments, please see below.
| */ | ||
| function encode(bytes memory data_) pure returns (bytes memory) { | ||
| unchecked { | ||
| uint256 size = data_.length; |
There was a problem hiding this comment.
I believe we can add validation inhere:
require(data_.length > 0, "Input data cannot be empty");
There was a problem hiding this comment.
Base58.sol is actually copy-paste of open source lib https://github.com/storyicon/base58-solidity/blob/master/contracts/Base58.sol
we can import it as a submodule, or we can leave it "as is" now and add improvements later
| bytes constant BTC_BECH32_MAINNET_BYTES = hex"626331"; // prefix = bc1 | ||
| bytes constant BTC_BECH32_TESTNET_BYTES = hex"746231"; // prefix = tb1 | ||
| bytes constant BTC_BECH32_REGTEST_BYTES = hex"6263727431"; // prefix = bcrt1 | ||
|
|
||
| string constant BTC_BECH32_MAINNET = 'bc'; | ||
| string constant BTC_BECH32_TESTNET = 'tb'; | ||
| string constant BTC_BECH32_REGTEST = 'brct'; |
There was a problem hiding this comment.
is it correct that first 3 constants contain 3 chars and last 3 only 2 chars?
There was a problem hiding this comment.
That is because it is just copy-paste of Aleksey's code into Mykola's code, keeping their codebases. That's the difference of their code styles :)
| string constant BTC_BECH32_TESTNET = 'tb'; | ||
| string constant BTC_BECH32_REGTEST = 'brct'; | ||
|
|
||
| //NB: don't forget to update `lnbtc_ext.go` when changing this enum! |
There was a problem hiding this comment.
this file is located in stroom-contracts and renamed already )
Move bitcoin utils togeather with its tests to this repo. This PR mostly copy-paste BitcoinUtils.sol from stroom-contracts. The only big change is introduction of BitcoinNetworkEncoder library, that is needed to unify network encoding enum across Bech32m and BitcoinUtils contracts.