-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groovy version upgrade for JG branch #135
Open
anki2189
wants to merge
31
commits into
strongbox:issues/1649
Choose a base branch
from
anki2189:issue-1854
base: issues/1649
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anki2189
force-pushed
the
issue-1854
branch
2 times, most recently
from
December 10, 2020 09:29
ca2b655
to
ffe0439
Compare
16 tasks
This pull request needs to be rebased, as it has a lot of noise and has a conflict. Will re-test after the rebase. |
- Upgrade the maven-resources plugin from 3.0.2 to 3.2.0
…ch in the strongbox-parent Fixed.
[skip ci]
…JDK 8 (or 11) Added maven version to error message for easier debugging.
…ch in the strongbox-parent It seems there is some sort of bug with the `maven-dependency-plugin` that causes a 401 when deploying to the repository through Jenkins. Reverting this to `2.8.2`.
Update the dependency version for commons-beanutils. Also fix the placement of the comment explaining the beanutils version override. It was moved upwards above a different dependency by another commit. This fixes strongbox/strongbox#1847
Rebased, not sure why it has commits from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes strongbox/strongbox#1705, #1854
Acceptance Test
strongbox-parent
withmvn clean install
still works.strongbox
project withmvn clean install -Dintegration.tests
still works.mvn spring-boot:run
in thestrongbox-web-core
still starts up the application correctly.strongbox-distribution
from azip
ortar.gz
still works.strongbox-web-integration-tests
still run properly.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?
Code Review And Pre-Merge Checklist