Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strongbox.yaml with strictchecksum option #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

newarcher36
Copy link

Add in strongbox.yaml strictchecksum property.
See --> strongbox/strongbox#1512

Add in strongbox.yaml strictchecksum property.
See --> strongbox/strongbox#1512
@ghost
Copy link

ghost commented Nov 1, 2019

DeepCode Report (#a01d4f)

DeepCode analyzed this pull request.
There are no new issues.

@@ -66,6 +66,7 @@ The following is an example of a `strongbox.yaml` configuration file:
type: hosted
allowsForceDeletion: true
checksumHeadersEnabled: true
strictChecksum: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change this to strictChecksumValidation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@@ -78,6 +79,7 @@ The following is an example of a `strongbox.yaml` configuration file:
type: hosted
secured: true
checksumHeadersEnabled: true
strictChecksum: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change this to strictChecksumValidation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newarcher36 ,

Could you please make the changes @ptirador suggested? Thanks! :)

@newarcher36
Copy link
Author

I am on it!

Changed from "strictChecksum" to "strictChecksumValidation"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants