Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleton retrieve method now requires params to be passed as the first argument #1456

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

prathmesh-stripe
Copy link
Contributor

Changelog

  • Singleton retrieve method now requires params to be passed as the first argument. Existing calls to singleton retrieve method with only opts argument will have to be updated to account for the addition of params argument.
params = { expand: ["available"] }
opts = { stripe_account: "acct_123" }

# ❌ No longer works
Stripe::Balance.retrieve(opts)

# ✅ Correct way to call retrieve method
Stripe::Balance.retrieve(params, opts)

@prathmesh-stripe prathmesh-stripe changed the base branch from master to next-major-infra September 26, 2024 18:39
@prathmesh-stripe prathmesh-stripe merged commit 698582a into next-major-infra Sep 26, 2024
1 check passed
@prathmesh-stripe prathmesh-stripe deleted the prathmesh/opts-param-fix branch September 26, 2024 18:49
@ramya-stripe ramya-stripe restored the prathmesh/opts-param-fix branch September 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants