Fix v2 event object name (#1403)

* changed the object_name for v2 events from "event" to "v2.core.event" * improved debug output in stripe_webhook_handler example, and removed incorrect comment
stripe · Sep 28, 2024 · c0e5da3 · c0e5da3
1 parent 52f5129
commit c0e5da3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/examples/stripe_webhook_handler.py b/examples/stripe_webhook_handler.py
@@ -24,9 +24,9 @@ def webhook():
         # Fetch the event data to understand the failure
         event = client.v2.core.events.retrieve(thin_event.id)
         if isinstance(event, V1BillingMeterErrorReportTriggeredEvent):
-            # CHECK: fetch_object is present and callable, returning a strongly-typed object (without casting)
             meter = event.fetch_related_object()
             meter_id = meter.id
+            print("Success! " + str(meter_id))
 
             # Record the failures and alert your team
             # Add your logic here

diff --git a/stripe/_util.py b/stripe/_util.py
@@ -321,7 +321,7 @@ def _convert_to_stripe_object(
         resp = resp.copy()
         klass_name = resp.get("object")
         if isinstance(klass_name, str):
-            if api_mode == "V2" and klass_name == "event":
+            if api_mode == "V2" and klass_name == "v2.core.event":
                 event_name = resp.get("type", "")
                 klass = get_thin_event_classes().get(
                     event_name, stripe.StripeObject

diff --git a/tests/test_stripe_client.py b/tests/test_stripe_client.py
@@ -38,7 +38,7 @@ def test_v2_events_retrieve(self, http_client_mock):
         http_client_mock.stub_request(
             method,
             path=path,
-            rbody='{"id": "evt_123","object": "event", "type": "v1.billing.meter.error_report_triggered"}',
+            rbody='{"id": "evt_123","object": "v2.core.event", "type": "v1.billing.meter.error_report_triggered"}',
             rcode=200,
             rheaders={},
         )

diff --git a/tests/test_v2_event.py b/tests/test_v2_event.py
@@ -16,7 +16,7 @@ def v2_payload_no_data(self):
         return json.dumps(
             {
                 "id": "evt_234",
-                "object": "event",
+                "object": "v2.core.event",
                 "type": "financial_account.balance.opened",
                 "created": "2022-02-15T00:27:45.330Z",
                 "related_object": {
@@ -37,7 +37,7 @@ def v2_payload_with_data(self):
         return json.dumps(
             {
                 "id": "evt_234",
-                "object": "event",
+                "object": "v2.core.event",
                 "type": "financial_account.balance.opened",
                 "created": "2022-02-15T00:27:45.330Z",
                 "related_object": {