Fix issue where multiple accounts are selected for single select #4187
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
commented
Oct 25, 2024
Comment on lines
+188
to
+191
| if self.dataSource.manifest.singleAccount { | ||
| if let firstEnabledAccount = accounts.first(where: \.allowSelectionNonOptional) { | ||
| self.dataSource.updateSelectedAccounts([firstEnabledAccount]) | ||
| } |
There was a problem hiding this comment.
@carlosmuvi-stripe Any thoughts on what we should do in the else block of this condition? This would be where no accounts have been selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue in the account picker pane where multiple account could be selected when both
skipAccountSelectionandmanifest.singleAccountistrue. Instead, we select the first selectable account.Motivation
Fixes bug reported by Doordash.
Testing
Manual testing via latest Testflight build on this branch. @carlosmuvi-stripe confirmed this fixes the issue!
Changelog
N/a