Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extending STPCardFormView with CardScanner functionality #4103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kuhash
Copy link

@Kuhash Kuhash commented Oct 7, 2024

Summary

Subclassed STPCardFormView to STPCardFormScannerView in order to add functionality of STPCardScanner.
Card scanning feature is done with STPCardScanner (with delegate) and STPCameraView.
STPCameraView is added to STPFormView’s vStack using addArrangedSubview and manipulated with constraints.

Changelog

  • [Moved] STPCameraView.swift from StripeiOS to StripePaymentsUI (import circle)
  • [Moved] STPCardScanner.swift from StripeiOS to StripePaymentsUI (import circle)
  • [Added] STPCardFormScannerView.swift

@Kuhash Kuhash requested review from a team as code owners October 7, 2024 13:57
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

@Kuhash
Copy link
Author

Kuhash commented Oct 10, 2024

Hi, can I ask to look into 'Pending — Wating for approval - stripe-ios' Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants