[FC] Consent pane - Snapshot tests #3753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
force-pushed
the
mats/fc_consent_pane_snapshot_testing
branch
3 times, most recently
from
a27d9b4
to
f707e1c
Compare
mats-stripe
commented
Jul 8, 2024
StripeFinancialConnections/StripeFinancialConnections/Source/FinancialConnectionsSheet.swift
Show resolved
Hide resolved
...eFinancialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentLogoView.swift
Show resolved
Hide resolved
StripeFinancialConnections/StripeFinancialConnectionsTests/ConsentPaneSnapshotTests.swift
Outdated
Show resolved
Hide resolved
StripeFinancialConnections/StripeFinancialConnectionsTests/ConsentPaneSnapshotTests.swift
Outdated
Show resolved
Hide resolved
StripeFinancialConnections/StripeFinancialConnections.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
kgaidis-stripe
previously approved these changes
Jul 8, 2024
kgaidis-stripe
previously approved these changes
Jul 9, 2024
mats-stripe
force-pushed
the
mats/fc_consent_pane_snapshot_testing
branch
from
ec61cec
to
347ee2f
Compare
mats-stripe
force-pushed
the
mats/fc_consent_pane_snapshot_testing
branch
from
347ee2f
to
754c21a
Compare
kgaidis-stripe
previously approved these changes
Jul 16, 2024
kgaidis-stripe
previously approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a snapshot test for the Financial Connections Consent pane. Since this is the first snapshot test in the FC project, this includes all the snapshot testing setup, such as adding the dependencies we need and some resource files.
Motivation
Snapshot tests give us confidence that UI changes don't unintentionally break UI anywhere. This PR is just the start, but we could eventually get coverage of every pane in the flow.
Testing
Nothing functional should be changed - this only adds a new test!
Changelog
N/a