Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the beta SDK for the payment_method_settings component #114

Merged

Conversation

ianharris-stripe
Copy link
Contributor

@ianharris-stripe ianharris-stripe commented Apr 22, 2024

This PR pulls in the latest stripe package version 15.5.0-beta.1 in order to support the payment_method_settings component. It also removes the TS hack that was necessary to include the component before this.

@ianharris-stripe ianharris-stripe force-pushed the ianharris/use-beta-sdk-for-payment-method-settings branch from 9087ee4 to f7893bc Compare April 25, 2024 16:44
@ianharris-stripe ianharris-stripe marked this pull request as ready for review April 26, 2024 00:57
@ianharris-stripe
Copy link
Contributor Author

r? @jorgea-stripe
New beta SDK was released today, hence the fix here!

@ianharris-stripe ianharris-stripe changed the title [WIP] Use the beta SDK for the payment_method_settings component Use the beta SDK for the payment_method_settings component Apr 26, 2024
Copy link
Collaborator

@jorgea-stripe jorgea-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this change!

@@ -472,16 +475,9 @@ app.post('/account_session', stripeAccountRequired, async (req, res) => {
},
};

// TODO: Move up once payment_method_settings is in the beta SDK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ianharris-stripe ianharris-stripe merged commit 0c1949c into master Apr 26, 2024
2 checks passed
@ianharris-stripe ianharris-stripe deleted the ianharris/use-beta-sdk-for-payment-method-settings branch April 26, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants