-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt-in to baas features #113
Conversation
0255fa4
to
fc0bc1a
Compare
}} | ||
onSuccess={async () => { | ||
await navigate('/onboarding'); | ||
navigate(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "works" -- the reason for the navigate + refresh is that when i navigate to /onboarding, the updated capability request isn't reflected yet, so when the user submits, they haven't attested to the issuing/treasury ToS. but with the refresh, it forces a reload (and delay?) so it gets picked up.
fc0bc1a
to
3e62f5c
Compare
3e62f5c
to
b0e7987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, left a couple of suggestions
capabilities, | ||
onSuccess, | ||
}: RequestCapabilitiesProps) => { | ||
const {mutate} = useRequestCapabilities(capabilities); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The loading and error state isn't used here (we should display a spinner/loading state and render an error if one occurred)
}, | ||
}} | ||
onSuccess={async () => { | ||
await navigate('/onboarding'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await navigate('/onboarding'); | |
// After requesting the capabilities successfully, we force a full page reload | |
await navigate('/onboarding'); |
Updating the flow to be opt-in to financial features. When the user is in a supportable connect config, render the
Finance
tab. If the user does not have the required capabilities yet, display a welcome screen the prompts the user to "enable". Clicking requests the capabilities, routes back to /onboarding, and depending on the capability requested, will create an FA.baas-2.mp4