Add Internal stripe tax embedded components #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isehrob-stripe
force-pushed
the
isehrob/tax-embedded-components
branch
from
ff427f2
to
c930ce5
Compare
isehrob-stripe
changed the title
slye-stripe
previously approved these changes
Apr 19, 2024
jorgea-stripe
requested changes
Apr 19, 2024
| return wrapper; | ||
| }; | ||
|
|
||
| export const ConnectTaxRegistrations = (): JSX.Element => { |
There was a problem hiding this comment.
Let's not add more of these, can you instead import these components from the SDK?
There was a problem hiding this comment.
(Note - I just merged a PR that does this, so you just have to rebase and import)
#111
There was a problem hiding this comment.
Done! Thanks!
| @@ -90,6 +91,14 @@ const router = createBrowserRouter([ | |||
| </AuthenticatedAndOnboardedRoute> | |||
| ), | |||
| }, | |||
| { | |||
| path: '/tax', | |||
There was a problem hiding this comment.
How will users know this URL exists? (did you intend to add a button somewhere, maybe from the profile page?)
There was a problem hiding this comment.
Good call out, thanks! I've added it the profile menu like this:
lmk if this makes sense.
There was a problem hiding this comment.
That makes sense to me!
isehrob-stripe
force-pushed
the
isehrob/tax-embedded-components
branch
from
b7bb6e2
to
63de3e2
Compare
jorgea-stripe
approved these changes
Apr 22, 2024
| @@ -90,6 +91,14 @@ const router = createBrowserRouter([ | |||
| </AuthenticatedAndOnboardedRoute> | |||
| ), | |||
| }, | |||
| { | |||
| path: '/tax', | |||
There was a problem hiding this comment.
That makes sense to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're adding 2 Stripe tax embedded components being launched in the private beta. This is how the new components look like:
Added tax as a menu item as well:
I've also updated the checkout session creation logic so that if the connected account activated tax, we can demonstrate how tax calculation works. Here's the walkthrough of the flow with different states of tax configuration for Checkout:
Screen.Recording.2024-04-19.at.16.26.37.mov