-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Internal stripe tax embedded components #110
Conversation
ff427f2
to
c930ce5
Compare
return wrapper; | ||
}; | ||
|
||
export const ConnectTaxRegistrations = (): JSX.Element => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add more of these, can you instead import these components from the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Note - I just merged a PR that does this, so you just have to rebase and import)
#111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks!
@@ -90,6 +91,14 @@ const router = createBrowserRouter([ | |||
</AuthenticatedAndOnboardedRoute> | |||
), | |||
}, | |||
{ | |||
path: '/tax', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will users know this URL exists? (did you intend to add a button somewhere, maybe from the profile page?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me!
b7bb6e2
to
63de3e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
@@ -90,6 +91,14 @@ const router = createBrowserRouter([ | |||
</AuthenticatedAndOnboardedRoute> | |||
), | |||
}, | |||
{ | |||
path: '/tax', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me!
In this PR we're adding 2 Stripe tax embedded components being launched in the private beta. This is how the new components look like:
Added tax as a menu item as well:
I've also updated the checkout session creation logic so that if the connected account activated tax, we can demonstrate how tax calculation works. Here's the walkthrough of the flow with different states of tax configuration for Checkout:
Screen.Recording.2024-04-19.at.16.26.37.mov