Skip to content

Commit

Permalink
Remove SD prefilling (#106)
Browse files Browse the repository at this point in the history
* Remove SD prefilling

Post Odyssey, the statement descriptor is prefilled automatically for
anything. So no need to prefill ourselves, as it might be wrong!

* update version to get new prefilling behavior

* update stripe sdk

* update mongodb instructions

* fix mongodb set up
  • Loading branch information
streeter-stripe authored Mar 26, 2024
1 parent c0f536f commit 657507b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 19 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ cp .env.example .env
Install MongoDB Community Edition. Refer to the [official documentation](https://www.mongodb.com/docs/manual/tutorial/install-mongodb-on-os-x/). Then, run MongoDB:

```
brew services start [email protected]
brew tap mongodb/brew && brew update
brew install [email protected]
brew services start [email protected]
```

Run the app:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"react-dom": "^18.2.0",
"react-query": "^3.39.3",
"react-router-dom": "^6.11.1",
"stripe": "13.5.0-beta.1",
"stripe": "^14.23.0-beta.1",
"typescript": "^4.5.5"
},
"devDependencies": {
Expand Down
12 changes: 0 additions & 12 deletions server/routes/stripe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,18 +286,6 @@ app.post('/create-account', userRequired, async (req, res) => {
: {}),
},
business_type: businessType,
...(shouldPrefill
? {
settings: {
card_payments: {
statement_descriptor_prefix: 'FurEver',
},
payments: {
statement_descriptor: 'FurEver',
},
},
}
: {}),
};
if (businessType === 'company') {
accountParams = Object.assign(accountParams, {
Expand Down
2 changes: 1 addition & 1 deletion server/routes/stripeSdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import dotenv from 'dotenv';
dotenv.config({path: './.env'});
export const stripe = new Stripe(process.env.STRIPE_SECRET_KEY, {
// @ts-ignore If you wish to remain on your account's default API version, you may pass null or another version instead of the latest version, and add a @ts-ignore comment here and anywhere the types differ between API versions.
apiVersion: '2023-08-16; embedded_connect_beta=v2;unified_accounts_beta=v1',
apiVersion: '2023-10-16; embedded_connect_beta=v2;unified_accounts_beta=v1',
});
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3154,10 +3154,10 @@ strip-ansi@^6.0.0, strip-ansi@^6.0.1:
dependencies:
ansi-regex "^5.0.1"

stripe@13.5.0-beta.1:
version "13.5.0-beta.1"
resolved "https://registry.yarnpkg.com/stripe/-/stripe-13.5.0-beta.1.tgz#74428046361be39c30019cf6960d322c36fafcb4"
integrity sha512-nZPlxwToP0QpthgoEJHOMUSPj6uUIkqy9VO3xXC6TDGuQuHZFoYKtFwRRs9P2X5QVK80cizAflyiEhmaeWMEwA==
stripe@^14.23.0-beta.1:
version "14.23.0-beta.1"
resolved "https://registry.yarnpkg.com/stripe/-/stripe-14.23.0-beta.1.tgz#03b23a79331cd95ebf6c24f9ccd9528702ef571f"
integrity sha512-qf7Ad6HXsWwXXG5qaQgAilQPBxU9cueW2nSfa52GxXGonzlwZxz041ihNuRpUxoBhM4jOxXkliQ50EHpgL+rNw==
dependencies:
"@types/node" ">=8.1.0"
qs "^6.11.0"
Expand Down

0 comments on commit 657507b

Please sign in to comment.