Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate base URLs #1264

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Validate base URLs #1264

merged 4 commits into from
Oct 18, 2024

Conversation

vcheung-stripe
Copy link
Collaborator

Reviewers

r? @
cc @stripe/developer-products

Summary

Validates that the --api-base and --dashboard-base debugging flags point to a valid domain name. This allows us to internally debug against the correct domain names.

I confirmed each command continues to work as expected.

@vcheung-stripe vcheung-stripe requested a review from a team as a code owner October 18, 2024 00:17
@vcheung-stripe vcheung-stripe merged commit 94c1bee into master Oct 18, 2024
7 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-validate-base-urls branch October 18, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants