Link Payment Method Rows UI #9681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
521b349
to
a694583
Compare
|
Diffuse output: APKDEXARSC |
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
2 times, most recently
from
f2827b1
to
36b7739
Compare
toluo-stripe
changed the title
Add screenshots Minor fixes clean up fix test theme Fix screenshots Remove strings remove unused payment details remove alpha Delete screenshots Update strings.xml Update screenshots Fix screenshots
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
1ccdab7
to
98a4d44
Compare
amk-stripe
reviewed
Nov 21, 2024
link/res/values/strings.xml
Outdated
| <!-- Default name for bank account payment method when bank name is unavailable --> | ||
| <string name="stripe_wallet_bank">Bank</string> | ||
| <!-- Accessibility description for Passthrough payment method --> | ||
| <string name="stripe_wallet_passthrough_description" translatable="false">Passthrough</string> |
There was a problem hiding this comment.
why is this not translatable? I would think that this word doesn't make sense in many languages
Comment on lines
50
to
53
| @JvmStatic | ||
| @Parameterized.Parameters(name = "{0}") | ||
| @SuppressWarnings("LongMethod") | ||
| fun data(): List<TestCase> { |
There was a problem hiding this comment.
for the screenshot tests where there's only one parameter, it doesn't seem to give us many benefits to make the test parameterized. I think it would make it harder for us to track down a test case that's failing and is also a bit less readable than e.g. using a helper function which would enable us to include just the relevant parameters for that test case
| onMenuButtonClick = onMenuButtonClick | ||
| ) | ||
| } | ||
| TabRowDefaults.Divider( |
There was a problem hiding this comment.
should the divider be included in the list itself, rather than on each individual list item? This seems like it would give us less control over something like not having a divider shown at the bottom of the list
| } | ||
|
|
||
| val showWarning = (paymentDetails as? Card)?.isExpired ?: false | ||
| if (showWarning && !isSelected) { |
There was a problem hiding this comment.
why do we not show the warning if the PM is selected? That is kind of surprising -- presumably a user would still want to know if their card is expired especially if they had selected that card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Compose UI for Link Payment Method Rows
Motivation
JIRA
Testing
Screenshots
Changelog