Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inline error for Link signups #9652

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Nov 18, 2024

Summary

This pull request improves error handling in the Link signup screen when used with Instant Bank Payments.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │     2 MiB │     2 MiB │ +541 B │   4.1 MiB │   4.1 MiB │ +184 B 
     arsc │     1 MiB │     1 MiB │    0 B │     1 MiB │     1 MiB │    0 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │    0 B 
      res │ 301.8 KiB │ 301.8 KiB │    0 B │ 455.5 KiB │ 455.5 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.1 KiB │   7.1 KiB │   -1 B │   6.9 KiB │   6.9 KiB │   -1 B 
    other │  90.2 KiB │  90.2 KiB │   -3 B │ 170.3 KiB │ 170.3 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │   9.6 MiB │   9.6 MiB │ +537 B │  21.5 MiB │  21.5 MiB │ +183 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 19966 │ 19966 │  0 (+3 -3) 
   types │  6188 │  6188 │  0 (+0 -0) 
 classes │  4979 │  4979 │  0 (+0 -0) 
 methods │ 29759 │ 29759 │  0 (+2 -2) 
  fields │ 17526 │ 17528 │ +2 (+3 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed     │   uncompressed    │                               
──────────┬────────┼──────────┬────────┤                               
 size     │ diff   │ size     │ diff   │ path                          
──────────┼────────┼──────────┼────────┼───────────────────────────────
    2 MiB │ +541 B │  4.1 MiB │ +184 B │ ∆ classes.dex                 
 28.4 KiB │   -4 B │ 62.9 KiB │    0 B │ ∆ META-INF/CERT.SF            
  6.3 KiB │   -1 B │  6.2 KiB │   -1 B │ ∆ assets/dexopt/baseline.prof 
  1.2 KiB │   +1 B │  1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼──────────┼────────┼───────────────────────────────
    2 MiB │ +537 B │  4.2 MiB │ +183 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   19966 │ 19966 │ 0 (+3 -3) 
  
  + VZLLLZLZZLILII
  + VZLLLZLZZLILLII
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"9df4753","r8-mode":"full","version":"8.7.14"}
  
  - VZLLLZLZZLII
  - VZLLLZLZZLILI
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1a8fa34","r8-mode":"full","version":"8.7.14"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   29759 │ 29759 │ 0 (+2 -2) 
  
  + P0.c j(boolean, U, n, e, boolean, Integer, boolean, boolean, n, int, String, p, int, int)
  + S3.W <init>(boolean, U, n, e, boolean, Integer, boolean, boolean, n, int, String, int, int)
  
  - P0.c j(boolean, U, n, e, boolean, Integer, boolean, boolean, n, int, p, int)
  - S3.W <init>(boolean, U, n, e, boolean, Integer, boolean, boolean, n, int, int)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   17526 │ 17528 │ +2 (+3 -1) 
  
  + S3.W Y: String
  + S3.W Z: int
  + S3.W a0: int
  
  - S3.W Y: int

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-signup-error-handling branch 2 times, most recently from caae1ca to bcdb5df Compare November 19, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant