-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blogpost: Managing connector offsets #452
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Katherine Stanley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left some comments about the stopping / unstopping of the connectors. But the blog pos look nice otherwise.
I wonder what you idea about the publication date is?
- We can wait and publish it after the 0.44.0 release in which case it just describes the feature as it is today.
- Or we can publish it before the release. But then we would need to frame the introduction as a preview of a feature that will be available in the next 0.44 release.
So I guess you aimed for the first option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well written, thanks @katheris.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, clear, useful post.
I left a few suggestions mainly around readability and clarity
Thanks for the review @scholzj. I think we should wait and publish it after the 0.44 release, I'll review the post and make sure it correctly reflects that plan. I think that will make it easier for people to follow. |
Signed-off-by: Katherine Stanley <[email protected]>
Thanks @scholzj, @see-quick, and @PaulRMellor for the reviews, I believe I have addressed all the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Signed-off-by: Katherine Stanley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post!
I left some comments.
I was also wondering if we should wait for Strimzi 0.44.0 being released before publishing it, because you are mentioning it at the beginning of the post.
Or we can just publish it and your sentence just warns users that they have to wait for the new release in order to use this feature.
I have no strong opinion on this.
Signed-off-by: Katherine Stanley <[email protected]>
@ppatierno thanks for your review, I've addressed your comments |
@ppatierno Jakub raised this before and we decided to publish it once 0.44 is out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Katherine Stanley <[email protected]>
Type of change
Select the type of your PR