Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogpost: Managing connector offsets #452

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

katheris
Copy link
Contributor

Type of change

Select the type of your PR

  • Typo/minor fix
  • New blog post (see the README for the process)
  • Other

Signed-off-by: Katherine Stanley <[email protected]>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some comments about the stopping / unstopping of the connectors. But the blog pos look nice otherwise.

I wonder what you idea about the publication date is?

  • We can wait and publish it after the 0.44.0 release in which case it just describes the feature as it is today.
  • Or we can publish it before the release. But then we would need to frame the introduction as a preview of a feature that will be available in the next 0.44 release.

So I guess you aimed for the first option?

@scholzj scholzj requested a review from a team September 27, 2024 08:57
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, thanks @katheris.

_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clear, useful post.
I left a few suggestions mainly around readability and clarity

_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
@katheris
Copy link
Contributor Author

I wonder what you idea about the publication date is?

  • We can wait and publish it after the 0.44.0 release in which case it just describes the feature as it is today.
  • Or we can publish it before the release. But then we would need to frame the introduction as a preview of a feature that will be available in the next 0.44 release.

So I guess you aimed for the first option?

Thanks for the review @scholzj. I think we should wait and publish it after the 0.44 release, I'll review the post and make sure it correctly reflects that plan. I think that will make it easier for people to follow.

@katheris
Copy link
Contributor Author

Thanks @scholzj, @see-quick, and @PaulRMellor for the reviews, I believe I have addressed all the comments

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Signed-off-by: Katherine Stanley <[email protected]>
Copy link

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post!
I left some comments.
I was also wondering if we should wait for Strimzi 0.44.0 being released before publishing it, because you are mentioning it at the beginning of the post.
Or we can just publish it and your sentence just warns users that they have to wait for the new release in order to use this feature.
I have no strong opinion on this.

_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
_posts/2024-09-26-managing-connector-offsets.md Outdated Show resolved Hide resolved
Signed-off-by: Katherine Stanley <[email protected]>
@katheris
Copy link
Contributor Author

katheris commented Oct 1, 2024

@ppatierno thanks for your review, I've addressed your comments

@katheris
Copy link
Contributor Author

katheris commented Oct 1, 2024

I was also wondering if we should wait for Strimzi 0.44.0 being released before publishing it, because you are mentioning it at the beginning of the post.
Or we can just publish it and your sentence just warns users that they have to wait for the new release in order to use this feature.
I have no strong opinion on this.

@ppatierno Jakub raised this before and we decided to publish it once 0.44 is out

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants