Fix Topic Operator metrics tests #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unamage topic metrics, where the operator should update total and successful reconciliations. Fixes a test issue where non existing metrics were silently ignored, instead of failing the test. Renames and completes the original tests with the missing metrics. Reduces the timeout used to wait for metric appearance from 120s to 30s (this change should be verified on Azure). Signed-off-by: Federico Valeri <[email protected]>
scholzj
approved these changes
May 19, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unmanage topic metrics, where the operator should update total and successful reconciliations. Fixes a test issue where non existing metrics were silently ignored, instead of failing the test. Renames and completes the original tests with the missing metrics. Reduces the timeout used to wait for metric appearance from 120s to 30s (this change should be verified on Azure).