fix: Use nondurable cursors for pulsar readers #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omegaphoenix
force-pushed
the
feature/non-durable-readers
branch
from
4f54cc0
to
2b91111
Compare
By default we set subscriptions to use a durable cursor: https://github.com/streamnative/pulsar-rs/blob/master/PulsarApi.proto#L352 We only run into this when durable is None which can also be avoided if we use Pulsar::reader() which also sets durable to Some(false). However, there are cases where users may overwrite the options before calling `into_reader()`.
omegaphoenix
force-pushed
the
feature/non-durable-readers
branch
from
2b91111
to
79aee8c
Compare
|
|
BewareMyPower
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Apache Pulsar documentation:
By default we set subscriptions to use a durable cursor:
https://github.com/streamnative/pulsar-rs/blob/master/PulsarApi.proto#L352
We only run into this when durable is None which can also be avoided
if we use Pulsar::reader() which also sets durable to Some(false).
However, there are cases where users may overwrite the options before
calling
into_reader().