Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lint task and apply #241

Merged
merged 11 commits into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
root = true

[*]
end_of_line = lf
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
22 changes: 19 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,23 @@ on:
branches: [ master ]

jobs:
build:
lint:
runs-on: ubuntu-latest
steps:
- name: Install protocol buffer compiler
uses: arduino/setup-protoc@v1
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v1
- name: Build
run: cargo build
- name: Check Clippy
run: cargo clippy --tests --all-features -- -D warnings
- name: Install nightly rustfmt
run: rustup toolchain install nightly --component rustfmt
- name: Check format
run: cargo +nightly fmt --all --check

test:
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -18,8 +34,8 @@ jobs:
- name: Start Pulsar Standalone Container
run: docker run --name pulsar -p 6650:6650 -p 8080:8080 -d -e GITHUB_ACTIONS=true -e CI=true streamnative/pulsar:${{ matrix.pulsar-version }} /pulsar/bin/pulsar standalone
- uses: actions/checkout@v3
- name: Build
run: cargo build --verbose
- uses: Swatinem/rust-cache@v1
- name: Build
run: cargo build
- name: Run tests
run: cargo test -- --nocapture
11 changes: 5 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
# Contributing to ulsar-rs
# Contributing to pulsar-rs

Thank you for your interest in contributing to pulsar-rs! There are many ways to contribute
and we appreciate all of them.
Thank you for your interest in contributing to pulsar-rs! There are many ways to contribute and we appreciate all of them.

As of 2022/08, maintainers of this repo have agreed to stabilize this repo since it's quality is not upto java pulsar client.
Thus, issues that are beyond pulsar version 2.10.x are welcomed but will not be prioritized until 2022/12.
If you would like to contribute to this crate, solving issues listed on this [page](https://github.com/streamnative/pulsar-rs/issues/224) is strongly encouraged.
As of 2022/08, maintainers of this repo have agreed to stabilize this repo since it's quality is not upto java pulsar client. Thus, issues that are beyond pulsar version 2.10.x are welcomed but will not be prioritized until 2022/12.

If you would like to contribute to this crate, solving issues listed on this [page](https://github.com/streamnative/pulsar-rs/issues/224) is strongly encouraged.

Thanks!
Loading