Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic selection topic & partition #77

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Support dynamic selection topic & partition #77

merged 3 commits into from
Aug 27, 2022

Conversation

hailin0
Copy link
Contributor

@hailin0 hailin0 commented Jul 21, 2022

Support dynamic selection topic & partition

#19
#64

@hailin0 hailin0 requested review from tuteng, a team and shoothzj as code owners July 21, 2022 07:02
@hailin0
Copy link
Contributor Author

hailin0 commented Jul 21, 2022

@zhongxp1219
@tyluffy
@sijie

Please help to review

@hailin0
Copy link
Contributor Author

hailin0 commented Jul 21, 2022

image
image

@shoothzj
Copy link
Collaborator

@hailin0 Thanks for your contribution. It looks good. I have a concern, when will the producer getting prune?
If the user selects a key field that varies greatly, is there a risk of memory leak? Could you please explain more? thanks! :)

@hailin0
Copy link
Contributor Author

hailin0 commented Jul 21, 2022 •
edited
Loading

@shoothzj

I use another solution in my company: lru-cache
I don't know if open source needs it

image

@hailin0
Copy link
Contributor Author

hailin0 commented Jul 21, 2022

@hailin0 Thanks for your contribution. It looks good. I have a concern, when will the producer getting prune? If the user selects a key field that varies greatly, is there a risk of memory leak? Could you please explain more? thanks! :)

@shoothzj

Use lru cache for dynamic producers

@zhongxp1219
Copy link
Contributor

great job, i think it is useful for beats to collect logs and metrics and so on.

@shoothzj
Copy link
Collaborator

LGTM @tuteng

@shoothzj
Copy link
Collaborator

ping @tuteng

@tuteng tuteng merged commit 9d68cff into streamnative:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoothzj shoothzj shoothzj approved these changes

@zhongxp1219 zhongxp1219 zhongxp1219 approved these changes

@tuteng tuteng Awaiting requested review from tuteng tuteng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hailin0 @shoothzj @zhongxp1219 @tuteng