Fixed remove offload use flag #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
MarvinCai
reviewed
Mar 25, 2022
charts/pulsar/values.yaml
Outdated
| @@ -1029,6 +1029,7 @@ broker: | |||
| annotations: {} | |||
| offload: | |||
| enabled: false | |||
| # Mark this flag as deprecated and remove it in the future, it is recommended to use the enabled flag to decide whether to enabled or disabled offload | |||
| use: true | |||
There was a problem hiding this comment.
if we've removed all presence of this value from Chart, I don't think we need to keep it anymore
|
@tuteng do this PR needs to update doc? Thanks |
github-actions
bot
removed
the
doc-info-missing
|
@tuteng:Thanks for providing doc info! |
No need for doc update |
tuteng
commented
Mar 28, 2022
| if [[ "x${UPGRADE}" == "xtrue" ]]; then | ||
| ci::upgrade_pulsar_chart ${CHARTS_HOME}/${VALUES_FILE} | ||
| fi | ||
| # if [[ "x${UPGRADE}" == "xtrue" ]]; then |
There was a problem hiding this comment.
The cluster upgrade test seems to block the current pr, I've disabled it for now, I created an issue and take a look at it later, it has no effect on sn-platform, #562
MarvinCai
approved these changes
Mar 28, 2022
fantapsody
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)