-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support UInt8Array
in place of Buffer
#1083
Conversation
I feel like this probably is a fix for #733 - would you mind double checking that for me, and throwing in a test or two as/when you think is needed? (if you don't think it's worth having any, I'm ok with that too 🙂) |
Awesome! Mind sticking a "resolves" line to your description? Re tests it doesn't surprise me but would still be good if we had at least one where were explicitly passing in a Uint8Array |
@G-Rath added to the description! I can add one before merge - no biggie. |
@G-Rath fixed. I also removed a |
Seems like there are some unrelated flakes failing - but test I added should be good. |
This seems reasonable, considering memfs supports the browser, and users are more likely to have instances of Uint8Array there.
Yeah that should never have been landed - I've opened #1086 to remove it and another from a test, just so we've got a dedicated changelog entry as it's a whole bug of its own
A couple of the watch ones are very slightly flakey, but thankfully only slightly so yes after rerunning you've got green across the board 🎉 |
UInt8Array
in place of Buffer
# [4.16.0](v4.15.4...v4.16.0) (2025-01-09) ### Features * support `UInt8Array` in place of `Buffer` ([#1083](#1083)) ([0d3662a](0d3662a))
🎉 This PR is included in version 4.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This seems reasonable, considering memfs supports the browser, and users are more likely to have instances of Uint8Array there.
Resolves #733