-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry mechanism addition to download bitcoind tarball #1393
Open
GitGab19
wants to merge
1
commit into
stratum-mining:main
Choose a base branch
from
GitGab19:add-retry-in-tp-tarball-download
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,16 +10,49 @@ use tar::Archive; | |||||
|
||||||
const VERSION_TP: &str = "0.1.13"; | ||||||
|
||||||
fn download_bitcoind_tarball(download_url: &str) -> Vec<u8> { | ||||||
let response = minreq::get(download_url) | ||||||
.send() | ||||||
.unwrap_or_else(|_| panic!("Cannot reach URL: {}", download_url)); | ||||||
assert_eq!( | ||||||
response.status_code, 200, | ||||||
"URL {} didn't return 200", | ||||||
download_url | ||||||
fn download_bitcoind_tarball(download_url: &str, retries: usize) -> Vec<u8> { | ||||||
for attempt in 0..retries { | ||||||
let response = minreq::get(download_url).send(); | ||||||
match response { | ||||||
Ok(res) if res.status_code == 200 => { | ||||||
return res.as_bytes().to_vec(); | ||||||
} | ||||||
Ok(res) if res.status_code == 503 => { | ||||||
// If the response is 503, log and prepare for retry | ||||||
eprintln!( | ||||||
"Attempt {}: URL {} returned status code 503 (Service Unavailable)", | ||||||
attempt + 1, | ||||||
download_url | ||||||
); | ||||||
} | ||||||
Ok(res) => { | ||||||
// For other status codes, log and stop retrying | ||||||
panic!( | ||||||
"URL {} returned unexpected status code {}. Aborting.", | ||||||
download_url, res.status_code | ||||||
); | ||||||
} | ||||||
Err(err) => { | ||||||
eprintln!( | ||||||
"Attempt {}: Failed to fetch URL {}: {:?}", | ||||||
attempt + 1, | ||||||
download_url, | ||||||
err | ||||||
); | ||||||
} | ||||||
} | ||||||
|
||||||
if attempt < retries - 1 { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
If above suggestion is accepted. |
||||||
let delay = 2u64.pow(attempt as u32); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
eprintln!("Retrying in {} seconds (exponential backoff)...", delay); | ||||||
std::thread::sleep(std::time::Duration::from_secs(delay)); | ||||||
} | ||||||
} | ||||||
// If all retries fail, panic with an error message | ||||||
panic!( | ||||||
"Cannot reach URL {} after {} attempts", | ||||||
download_url, retries | ||||||
); | ||||||
response.as_bytes().to_vec() | ||||||
} | ||||||
|
||||||
fn read_tarball_from_file(path: &str) -> Vec<u8> { | ||||||
|
@@ -105,7 +138,7 @@ impl TemplateProvider { | |||||
"{}/sv2-tp-{}/{}", | ||||||
download_endpoint, VERSION_TP, download_filename | ||||||
); | ||||||
download_bitcoind_tarball(&url) | ||||||
download_bitcoind_tarball(&url, 5) | ||||||
} | ||||||
}; | ||||||
|
||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.